Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Show full names in gup check output #171

Closed
Frederick888 opened this issue Sep 10, 2024 · 1 comment · Fixed by #172
Closed

[Feature Request] Show full names in gup check output #171

Frederick888 opened this issue Sep 10, 2024 · 1 comment · Fixed by #172

Comments

@Frederick888
Copy link

Is your feature request related to a problem?

For example, this is part of the gup check output on my machine:

$ gup check -j 1
check binary under $GOPATH/bin or $GOBIN
[ 9/30] golang.org/x/tools (current: v0.16.1, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[12/30] golang.org/x/tools (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[14/30] golang.org/x/tools (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[28/30] golang.org/x/tools (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)

If you want to update binaries, run the following command.
           $ gup update deptree staticcheck gomodifytags gocode goplay godef gore deadcode iferr asmfmt gorename go-mod-outdated goimports dlv errcheck fillstruct golangci-lint depth impl msgp gotags golint gotestsum keyify revive motion guru richgo go-checksum

It's hard to differentiate binaries from the same module.

Describe the solution you'd like

Show the full names like gup list

$ gup list | rg x/tools/cmd
       deadcode: golang.org/x/tools/cmd/deadcode@v0.16.1
      goimports: golang.org/x/tools/cmd/goimports@v0.16.2-0.20231226175357-025ebe628124
       gorename: golang.org/x/tools/cmd/gorename@v0.16.2-0.20231226175357-025ebe628124
           guru: golang.org/x/tools/cmd/guru@v0.16.2-0.20231226175357-025ebe628124

# what I want
$ gup check
[ 9/30] golang.org/x/tools/cmd/deadcode (current: v0.16.1, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[12/30] golang.org/x/tools/cmd/goimports (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[14/30] golang.org/x/tools/cmd/gorename (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[28/30] golang.org/x/tools/cmd/guru (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)

or something like

$ gup check -j 1
[ 9/30] deadcode golang.org/x/tools (current: v0.16.1, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[12/30] goimports golang.org/x/tools (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[14/30] gorename golang.org/x/tools (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)
[28/30] guru golang.org/x/tools (current: v0.16.2-0.20231226175357-025ebe628124, latest: v0.25.0 / current: go1.21.5, installed: go1.23.1)

Describe alternatives you've considered

Cross reference the gup list output.

Additional context

N/A

@nao1215
Copy link
Owner

nao1215 commented Sep 10, 2024

@Frederick888
Thank you for your feature request.
What you pointed out was a bug in the gup check command, which will be fixed in v0.27.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants