Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Juniper format option for get_config so JSON format can be selected #1105

Open
1 task done
robobeaver6 opened this issue Jan 8, 2020 · 1 comment
Open
1 task done

Comments

@robobeaver6
Copy link

Description of Issue/Question

Feature Request:

For get_config against Juniper switches, currently the format option is hard coded to "format"="text". Juniper supports JSON format for the show configuration, which is much better to work with programmatically. The underlying jnpr.junos.Device module supports JSON format.

Did you follow the steps from https://github.com/napalm-automation/napalm#faq

(Place an x between the square brackets where applicable)

  • Yes
  • [] No

Setup

N/A

napalm version

(Paste verbatim output from pip freeze | grep napalm between quotes below)

napalm==2.5.0
napalm-asa==0.1.1

Network operating system version

(Paste verbatim output from show version - or equivalent - between quotes below)

Model: ex4300-48p
Junos: 18.1R3-S7.1

Steps to Reproduce the Issue

N/A

Error Traceback

(Paste the complete traceback of the exception between quotes below)


@mirceaulinic
Copy link
Member

This sounds good to me. If you're willing to open a PR for this, please make sure to add the argument for all the core drivers (even though for some it may not make sense, the NAPALM API must be consistent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants