NX-OS using nx-api fails on get_bgp_neighbors if peer is admin down

[ktbyers]

No description provided.

[ktbyers]

@carl Can you see if you can reproduce this? If so, then we should add a unit test for it and correct the behavior.

Probably should also sanity check the same thing on NX-OS SSH

[robobeaver6]

I am hitting this issue. It seems to occur on Line894
on neighbors where the state resolves to Shut (Admin), which is not in the bgp_state_dict lookup dict.

[deep-blue-pulsar]

Currently hitting this issue with napalm 4.0.0

Traceback (most recent call last):
  File "/home/[REDACTED]/myvenv/bgp_test.py", line 14, in <module>
    output = device.get_bgp_neighbors()
  File "/home/[REDACTED]/myvenv/lib/python3.9/site-packages/napalm/nxos/nxos.py", line 1100, in get_bgp_neighbors
    bgp_state = bgp_state_dict[state]
KeyError: 'Shut (Admin)'

[rich9474]

I think this has a pretty simple fix. The nxos.py file just needs an extra state to match the different format of the device response.

    def get_bgp_neighbors(self) -> Dict[str, models.BGPStateNeighborsPerVRFDict]:
        results = {}
        bgp_state_dict = {
            "Idle": {"is_up": False, "is_enabled": True},
            "Active": {"is_up": False, "is_enabled": True},
            "Open": {"is_up": False, "is_enabled": True},
            "Established": {"is_up": True, "is_enabled": True},
            "Closing": {"is_up": True, "is_enabled": True},
            "Shutdown": {"is_up": False, "is_enabled": False},
            "Shut (Admin)": {"is_up": False, "is_enabled": False},