-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submodule npe2
instead of cloning in CI
#295
Comments
cc @melissawm |
So. Submodule is pinning given reference of submodule repository. So it means additional maintenance steep to synchronize with releases of npe2. Current code first clone, then checkout revision that fits to latest released npe2 version. |
If we are just cloning Currently, this is what we do: https://github.com/napari/docs/blob/0c7029e5c9674e9d56c5efbec1022fa302661280/docs/_scripts/prep_docs.py#L26C1-L26C74 |
I'll do some research on whether we would get any clear benefits from using a submodule (discussed in the docs WG meeting) |
Should/could we submodule
npe2
instead of explicitly cloning it inprep_docs.py
Discussed: #291 (comment)
The text was updated successfully, but these errors were encountered: