Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite icon change #438

Closed
shraddha761 opened this issue Jun 5, 2023 · 12 comments · Fixed by #570
Closed

Favorite icon change #438

shraddha761 opened this issue Jun 5, 2023 · 12 comments · Fixed by #570

Comments

@shraddha761
Copy link
Contributor

shraddha761 commented Jun 5, 2023

Description

icon which is used to add to favorite is not recognized easily it should be changed and make it reactive and align it to right side

Steps to reproduce

change favorite icon

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response

@shraddha761 shraddha761 added the bug label Jun 5, 2023
@narayan954
Copy link
Owner

icon which is used to add to favorite is not recognized easily it should be changed

can you make it reactive as well, so it changes on a click/hover? Also, change it's position to be on right most side instead of left most.
Actually, as per new guidelines, issues like just changing an icon/sentence on readme/color are not permitted for points, so we've to make compound issues for such issues.

@shraddha761
Copy link
Contributor Author

@narayan954 I'll do to suggest changes and will you please provide me some time reason being my exams are going on

@narayan954
Copy link
Owner

@narayan954 I'll do to suggest changes and will you please provide me some time reason being my exams are going on

yes, please take your time :)

@shraddha761
Copy link
Contributor Author

shraddha761 commented Jun 22, 2023

@narayan954 Please assign this issue so that I'll work on it

@narayan954
Copy link
Owner

narayan954 commented Jun 22, 2023

@narayan954 Please assign this issue so that I'll work on it

You can work on this, the issue is all yours :)
I forgot to assign earlier

@shraddha761
Copy link
Contributor Author

@narayan954 Please assign this issue so that I'll work on it

You can work on this, the issue is all yours :) I forgot to assign earlier

Ohh thank you

@shraddha761
Copy link
Contributor Author

@narayan954 dummygram didn't have discord Channel ?

This was referenced Jun 25, 2023
@narayan954 narayan954 linked a pull request Jun 26, 2023 that will close this issue
@narayan954
Copy link
Owner

@narayan954 dummygram didn't have discord Channel ?

Dummygram does have it's channel in gssoc server. Are you not able to access it?

@shraddha761
Copy link
Contributor Author

@narayan954 dummygram didn't have discord Channel ?

Dummygram does have it's channel in gssoc server. Are you not able to access it?

yahh

@narayan954
Copy link
Owner

@narayan954 dummygram didn't have discord Channel ?

Dummygram does have it's channel in gssoc server. Are you not able to access it?

yahh

Did you try it from self roles?

@shraddha761
Copy link
Contributor Author

@narayan954 dummygram didn't have discord Channel ?

Dummygram does have it's channel in gssoc server. Are you not able to access it?

yahh

Did you try it from self roles?

Now get channel

@narayan954
Copy link
Owner

@narayan954 dummygram didn't have discord Channel ?

Dummygram does have it's channel in gssoc server. Are you not able to access it?

yahh

Did you try it from self roles?

Now get channel

cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants