Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(classes): add shim file for browsers #354

Merged
merged 2 commits into from
Oct 7, 2021
Merged

feat(classes): add shim file for browsers #354

merged 2 commits into from
Oct 7, 2021

Conversation

micalevisk
Copy link
Contributor

Closes #353

@nartc
Copy link
Owner

nartc commented Oct 5, 2021

@micalevisk so I have a quick question. If we use the Transformer Plugin which does not use the AutoMapper() decorator, would this shim still be required on the frontend?

@micalevisk
Copy link
Contributor Author

Looks like with that plugin this shim won't be required. But what about the limitations it has?

image

@nartc
Copy link
Owner

nartc commented Oct 5, 2021

Looks like with that plugin this shim won't be required. But what about the limitations it has?

image

Yeah cool :D. Just want to make sure I understand the purpose of this shim. Would you be able to also add a section to the docs on how one would use the shim?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nartc
Copy link
Owner

nartc commented Oct 7, 2021

Thanks for the PR

@nartc nartc merged commit 4feff72 into nartc:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide shim file
2 participants