Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to make sure each required macro is set #32

Open
BaldBeacon opened this issue Aug 7, 2019 · 2 comments
Open

Add checks to make sure each required macro is set #32

BaldBeacon opened this issue Aug 7, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@BaldBeacon
Copy link
Contributor

In addition to the documentation mentioning what macros need to be set in the interface file for an app, there should be a compile time warning alerting the user to undefined values.

It might also be prudent to add validity checks against the entered values (for example when a bad MID was provided or a name exceeds a max value for the cfe).

@BaldBeacon BaldBeacon added the enhancement New feature or request label Aug 7, 2019
@SpaceSteve121
Copy link
Contributor

Doesn't the compiler already check if a macro is referenced without being defined? Is there some additional information that implementing this check in code could provide that the compiler doesn't?

@BaldBeacon
Copy link
Contributor Author

It might be nice for a user to get a message indicating what/where the value should be but yeah the compiler warning should be enough to tell the user that a value isn't present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants