Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter the sample app compiler flag to satisfy the cFS-GroundSystem #39

Open
BaldBeacon opened this issue Sep 17, 2019 · 3 comments
Open
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@BaldBeacon
Copy link
Contributor

The latest commit of the cFS-Groundsystem includes glibc specific features specifically the inclusion of the struct addrinfo. The addrinfo struct definition is only exposed in gcc when passed a gnu compliant standard (the current test cmake definition uses -std=c99).

More information on the topic of C standard compliance vs the GNU libraries can be found on this stack overflow post: https://stackoverflow.com/questions/33076175/why-is-struct-addrinfo-defined-only-if-use-xopen2k-is-defined

@BaldBeacon BaldBeacon self-assigned this Sep 17, 2019
@SpaceSteve121
Copy link
Contributor

@BaldBeacon If this was added to a CFS dependency, shouldn't the build configuration of the relevant CFS repo have been updated to add that compiler flag in? Do we know why its up to the user to set a flag for a dependency of the CFS repo?

@BaldBeacon
Copy link
Contributor Author

Since it's in the tools directory, from my knowledge the compilation options are sent by the user. If there was a means to say "only compile X tool with Y options" that would be the best case.

@BaldBeacon
Copy link
Contributor Author

Due to some other problems with the current master of cFS (defined #38) this is on hold.

@BaldBeacon BaldBeacon added bug Something isn't working wontfix This will not be worked on labels Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants