Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for command APID when command queue defined #44

Open
SpaceSteve121 opened this issue Oct 24, 2019 · 2 comments
Open

Add check for command APID when command queue defined #44

SpaceSteve121 opened this issue Oct 24, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@SpaceSteve121
Copy link
Contributor

The segfault in issue #42 was caused by specifying a command MID with a message not defined as a command (and which thus had no queue defined for it). The ECI code blindly attempted to utilize the queue which didn't exist, causing the segfault.

During the course of resolving that issue it was determined that a check can be done here to confirm the that there's a queue allocated if the MID indicates the message is a command.

That check would look something like if MsgRcv[idx].MsgStruct->qptr == NULL, issue an error event message warning the user about a misconfiguration, and either

  • skip the configuration of the queue for that message (if we can establish that the app will still work without it)
  • exit the app, if its going to be too broken to function

Work needs to be done to determine the correct course of action and implement this check.

@SpaceSteve121 SpaceSteve121 added the enhancement New feature or request label Oct 24, 2019
@SpaceSteve121
Copy link
Contributor Author

@BaldBeacon Can you take a look at this when you have time?

@SpaceSteve121
Copy link
Contributor Author

work started in 44-add_cmd_apid_check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant