Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataDrivenLearning plugins to add module to sys #47

Closed
asgibson opened this issue Sep 29, 2023 · 1 comment
Closed

Update DataDrivenLearning plugins to add module to sys #47

asgibson opened this issue Sep 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@asgibson
Copy link
Contributor

During experimentation it was found that directly including the <module_name>_plugin was not sufficient to use an external package. Instead, it was beneficial to include the entire external package as the module, add it to sys, then create a <module_name>_plugin.Plugin instance. This allows the external Plugin to access its packages modules.

The simple generic_plugin did not experience this effect because it was not accessing any otherwise unavailable packages and it housed within the onair directory structure. Experimental external packages suffered the effect because of their more complex structure.

@asgibson asgibson added the enhancement New feature or request label Sep 29, 2023
@asgibson asgibson added this to the OnAIR 1.0 refactor milestone Sep 29, 2023
@asgibson
Copy link
Contributor Author

asgibson commented Nov 2, 2023

This was addressed in #55 and merged with #58

@asgibson asgibson closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant