Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Moving Saving Results Functionality to Plugin #91

Open
the-other-james opened this issue Dec 4, 2023 · 2 comments
Open

Consider Moving Saving Results Functionality to Plugin #91

the-other-james opened this issue Dec 4, 2023 · 2 comments

Comments

@the-other-james
Copy link
Contributor

The '--save' flag saves execution results to a file, but is not currently used/supported within plugins. I think this functionality could actually be moved to a plugin that writes the high level dictionary to a file that can then be optionally included. From an internal discussion:

Why this is better implemented in a plugin:

  1. We want to keep the execution engine simple <- a simple implementation is possible, but we may want to support multiple file formats. Or making sure you don't overrun your disk quota. I would rather keep execution engine simple and implement a simple version in a plugin. Folks that just need the dumb version are all set. Folks that need more complicated logic can implement there own plugin based off of our example.
  2. No every use case will want the functionality <- for example hardware may not have the resources to constantly write out to disk. Or someone running experiments with the goal of repeatability may want very verbose output.
  3. The plugin architecture already exists
@asgibson
Copy link
Contributor

I think OnAIR should provide a rudimentary save feature that can at least record some data/results. It could be able to be turned on or off via config file. The plugin structure looks to be more centered on AI constructs and not simple operations like saving data. However, if someone desired a more complex saving structure, there is nothing stopping them from using a plugin or adding such a feature to a plugin. The last Complex Reasoner plugin would be an ideal location for such a saver as it should have access to all previous results.

@the-other-james
Copy link
Contributor Author

I think the csv_output plugin (https://github.com/nasa/OnAIR/blob/main/plugins/csv_output/csv_output_plugin.py) gives us the functionality we need by writing low and high-level data out to a file.

@asgibson do you object to me removing the --save flag and related functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants