Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE ES unit test failures caused by startup sync fix #105

Closed
skliper opened this issue Sep 30, 2019 · 3 comments
Closed

CFE ES unit test failures caused by startup sync fix #105

skliper opened this issue Sep 30, 2019 · 3 comments
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

The startup sync fix (#71) caused some unit test failures.

This is due to the fact that the counters never get incremented as expected, since this is done by the child thread. Therefore the verification that the child thread actually started cannot be unit tested.

As an interim fix this check will be removed from the main code. This will make unit tests pass in 6.4.2. Ironically, this is making the main code slightly less robust in order to appease unit tests.

In the future a unit test "hook" function can be implemented for {{{OS_TaskCreate()}}} that imitates the counter increment so the startup verification can be but back in at that time.

@skliper skliper added this to the 6.4.2 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 74. Created by jphickey on 2015-06-24T10:59:21, last modified: 2015-07-02T11:37:21

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-06-24 11:13:28:

Submitted [changeset:bbbb963] on branch {{{trac-74-startup-sync-ut-fix}}} that back ports my workarounds for this specific UT issue.

NOTE - the branch is based on {{{ic-hotfix-6-4-2}}}

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-07-02 11:37:21:

It was decided that this would NOT be included in 6.4.2, and the release would be published with the ES unit test "as-is".

As this originally was only a back port of a piece of a larger change set (#103) this ticket will be closed. #103 has all modifications needed to make the current development unit tests work.

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant