You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The startup sync fix (#71) caused some unit test failures.
This is due to the fact that the counters never get incremented as expected, since this is done by the child thread. Therefore the verification that the child thread actually started cannot be unit tested.
As an interim fix this check will be removed from the main code. This will make unit tests pass in 6.4.2. Ironically, this is making the main code slightly less robust in order to appease unit tests.
In the future a unit test "hook" function can be implemented for {{{OS_TaskCreate()}}} that imitates the counter increment so the startup verification can be but back in at that time.
The text was updated successfully, but these errors were encountered:
It was decided that this would NOT be included in 6.4.2, and the release would be published with the ES unit test "as-is".
As this originally was only a back port of a piece of a larger change set (#103) this ticket will be closed. #103 has all modifications needed to make the current development unit tests work.
The startup sync fix (#71) caused some unit test failures.
This is due to the fact that the counters never get incremented as expected, since this is done by the child thread. Therefore the verification that the child thread actually started cannot be unit tested.
As an interim fix this check will be removed from the main code. This will make unit tests pass in 6.4.2. Ironically, this is making the main code slightly less robust in order to appease unit tests.
In the future a unit test "hook" function can be implemented for {{{OS_TaskCreate()}}} that imitates the counter increment so the startup verification can be but back in at that time.
The text was updated successfully, but these errors were encountered: