-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2175, Apply consistent Event ID names to common events #2176
base: main
Are you sure you want to change the base?
Fix #2175, Apply consistent Event ID names to common events #2176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good improvement on the event names, we should consider adding a paragraph to https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md that focuses on event names to document how the name should be constructed.
Yes good point - I will draft something up today and add it to that markdown doc. |
7fd6661
to
b306ca5
Compare
I added the following section to the naming convention doc and squashed all the commits together now for merging. |
Removed the paragraph 8. that I added (see https://github.com/nasa/cFE/compare/4885bd1aacb0506e7784ac14931c09a48670fd9e..4820e166ef0bb0ebe7c074a0f8dbd0e2eeb6148f#) as something similar is already now present since #2254. |
21e0856
to
9a39e73
Compare
d3f4a25
to
4885bd1
Compare
4885bd1
to
4820e16
Compare
4820e16
to
6dbdcc6
Compare
6dbdcc6
to
5e93dec
Compare
5e93dec
to
f05436b
Compare
Checklist
Describe the contribution
Testing performed
Only GitHub CI actions.
Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.
Contributor Info
Avi Weiss @thnkslprpt