fix #2316 - CFE_TIME_Print() calls strftime() #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
changed the title
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| UT_GenStub_AddParam(CFE_TIME_Print, char *, PrintBuffer); | ||
| UT_GenStub_AddParam(CFE_TIME_Print, CFE_TIME_SysTime_t, TimeToPrint); | ||
|
|
||
| UT_GenStub_Execute(CFE_TIME_Print, Basic, UT_DefaultHandler_CFE_TIME_Print); | ||
|
|
||
| return UT_GenStub_GetReturnValue(CFE_TIME_Print, CFE_Status_t); |
Check warning
Code scanning / CodeQL
Uses of recursion
| { | ||
| UT_GenStub_SetupReturnBuffer(CFE_TIME_Print, CFE_Status_t); |
Check warning
Code scanning / CodeQL
Uses of recursion
| @@ -305,12 +305,16 @@ | |||
| * Generated stub function for CFE_TIME_Print() | |||
| * ---------------------------------------------------- | |||
| */ | |||
| void CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint) | |||
| CFE_Status_t CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint) | |||
Check notice
Code scanning / CodeQL
Long function without assertion
| @@ -563,150 +565,30 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| void CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint) | |||
| CFE_Status_t CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint) | |||
Check notice
Code scanning / CodeQL
Long function without assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
CFE_TIME_Print() calls strftime to format times and returns a status code rather than creating a syslog entry. Note that this may be expanded to allow this to be configurable or parameterized (although EVS may just call strftime directly.)
Re-introduced from #2356. #2388, #2389 reverted this PR.
Also collapsed epoch defines to SECONDS and MICROS for more performance and simpler configuration.
Testing performed
Standard build and UT tests updated.
Expected behavior changes
Function returns CFE_Status_t status.
NOTE strftime uses time_t which may be 32- or 64-bit and may be signed or unsigned, depending on the platform.
System(s) tested on
Ubuntu 22.04LTS
Additional context
https://en.wikipedia.org/w/index.php?title=Time_t&oldid=450752800
Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Christopher.D.Knight@nasa.gov