Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiting an Application Creates an Application with an Unknown State (GSFC DCR 23035) #89

Closed
skliper opened this issue Sep 30, 2019 · 11 comments
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

ES will continually send out event message #79 - "ES_ProcControlReq: Unknown State ( %d ) Application %s", with the unknown state set to 1, when an application exits via the CFE_ES_ExitApp API function call. See attached email thread for more details.

@skliper skliper added this to the 6.7.0 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 58. Created by sstrege on 2015-05-27T16:22:47, last modified: 2019-07-03T13:15:28

@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2016-10-18 15:00:28:

redispatching these tickets to clear my name from the "owner" field,
so people willing to work on tickets will not think that I am already
working these issues ;)

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2016-11-08 14:17:08:

Current crop of cfe-next are all going into CFE 6.6

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jwilmot on 2018-06-26 14:25:53:

Confirmed as bug 06/26/18

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-04-15 09:35:47:

I tracked this down and have a fix.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-04-22 16:46:04:

This is ready for CCB review and merge. Commit [changeset:65fa061] on branch trac-58-fix-unknown-state-after-exit

Summary: This occurs when applications call CFE_ES_ExitApp() without first setting an appropriate control command for the exit. The state number "1" cited in the description corresponds to the APP_RUN state, which would be the typical value for a running app that has received no exit request. Normally it would expected that the app would get an exit request via its control command first, but this situation arises when this command path is //not// followed, and the app exits itself voluntarily.

The solution has 2 parts:

  • Make sure that CFE_ES_ExitApp() also updates the control command to something appropriate for apps that self-exit. Avoid leaving it as APP_RUN, which is an unexpected combination.
  • In case the unexpected does occur and an app //is// left in an unexpected combination, avoid looping endlessly by setting the control command to SYS_DELETE. On the next scan iteration, the app will be cleaned up and the entry freed. Thus, only one syslog error message occurs, rather than an endless stream.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-05-08 13:52:58:

CCB 5/8/2019 - Code reviewed and approved

Joe - can you add to next convenient ic branch?

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-05-09 12:45:43:

Merged into branch ic-ccb-20190508

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-05-15 14:39:07:

CCB 5/15/2019 - Approved for merge to development branch

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-05-15 14:50:15:

Merged to development branch

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-03 13:15:28:

Moved closed tickets targeting 6.6.1 to 6.7.0 end of summer release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant