-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating install instructions for macOS #177
base: main
Are you sure you want to change the base?
Conversation
* brew to install pyqt5 * instead brew to install zeromq, install pyzmq via pip3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should instead use pip3 to install pyqt5.
See https://stackoverflow.com/questions/34583811/how-can-i-install-pyqt5-on-mac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested pip3 based installation. It works as expected.
Using pip3 instead of brew
@astrogeco - i am not able to clearly understand the changes requested by you. |
My bad, I misread your changes. We're good to go! |
Last step, if you haven't done so already, please download, sign, and email the appropriate Contributor License agreement below to GSFC-SoftwareRelease@mail.nasa.gov and cfs-program@lists.nasa.gov. Corporate Contributor License agreement Thank you so much or your contribution! |
@rokrsa can you submit the CLA? |
CCB 8 September 2022: Need issue and need to test steps. |
@rokrsa Thank you for your contribution! I'm going through some of the older PRs to see if we can get them merged in. Would you be able to create an issue for this and add some testing steps? |
21 November 2022: Will discuss closing at next CCB due to missing CLA. |
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Personal