Fix misleading wording in Commands-Telemetry.md #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix nasa#248, the original wording misleads readers to believe that the default port for receiving telemetry is 1234, in reality it being 1235, and the former being the port that the telemetry app uses to listen for commands.
|
I fixed the commit description, checks should pass now. |
|
Thank you @vladvoicux64 for your contribution! Would you be able to submit a CLA? The CLA forms are: cFS-Framework Individual CLA (if you're contributing in a personal capacity) Once you sign the appropriate CLA, can you submit it to GSFC-SoftwareRelease@mail.nasa.gov and copy cfs-program@lists.nasa.gov? Let me know if you have any questions. |
|
Hello, I filled and sent the CLA. Please confirm I correctly did so when possible. Thank you. |
Got it, thanks! |
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Feb 25, 2025
*Combines:* osal equuleus-rc1+dev97 sample_app equuleus-rc1+dev50 cFS-GroundSystem equuleus-rc1+dev18 **Includes:** *osal* -nasa/osal#1493 *sample_app* -nasa/sample_app#235 *cFS-GroundSystem* -nasa/cFS-GroundSystem#249 Co-authored by: Leigh Garbs <leighgarbs@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Voicu Ioan Vladut <vladvoicux64@users.noreply.github.com>
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Feb 25, 2025
*Combines:* osal equuleus-rc1+dev97 sample_app equuleus-rc1+dev50 cFS-GroundSystem equuleus-rc1+dev18 **Includes:** *osal* -nasa/osal#1493 *sample_app* -nasa/sample_app#235 *cFS-GroundSystem* -nasa/cFS-GroundSystem#249 Co-authored by: Leigh Garbs <leighgarbs@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Voicu Ioan Vladut <vladvoicux64@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original wording misleads readers to believe that the default port for receiving telemetry is 1234, in reality it being 1235, and the former being the port that the telemetry app uses to listen for commands.
Describe the contribution
Fixes #248 by improving the wording and adding information obtained by research
Testing performed
Tested using
ssandtcpdumpto track listening ports and sent packets. Proof can be found in the addressed issue.Expected behavior changes
Readers will hopefully not be mislead in the future and will correctly understand the ports involved.
System(s) tested on
Hardware: M1 Ultra chipset
OS: Debian 12.5 ARM64
Versions: cFS-GroundSystem Aquilla release
Contributor Info - All information REQUIRED for consideration of pull request
Voicu Ioan-Vladut, Personal