Commit format-check job doesn't run on push triggers

[astrogeco]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug

When a new commit is pushed the commit format checker job in the format-check workflow does not run unless the commit is part of a pull request.

To Reproduce

Create new branch
Push commit with non-standard message to remote
Observe "Commit check" job skip

Expected behavior

Pull request format check is skipped
Commit format check executes

Code snips

cFS/.github/workflows/format-check.yml

Lines 69 to 76 in ff88a1e

	check-commit-message:
	name: Check Commit Message
	needs: check-for-duplicates
	# Only run for pull-requests.
	if: ${{ github.event_name == 'pull_request' }}
	runs-on: ubuntu-18.04
	timeout-minutes: 15
	steps:

The if statement should apply to the PR check step instead of the whole job

System observed on:

Github Actions. See screenshot for example

Additional context

None

Reporter Info

Gerardo E. Cruz-Ortiz | NASA

[skliper]

Do we need to check the commit message if it isn't part of a pull request? I push things for testing frequently that aren't ever intended for a pull request, so they don't follow the rules so it would just be noise.

[astrogeco]

Do we need to check the commit message if it isn't part of a pull request? I push things for testing frequently that aren't ever intended for a pull request, so they don't follow the rules so it would just be noise.

That's a good point. I only noticed it because it didn't run on the merge to main for PRs and I wanted to see "all greens". We can close as "won't fix"