Fix #1419, Resolve sequence count auto-increment rollover bug #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
skliper
force-pushed
the
fix1419-get_next_seqcnt
branch
from
0a0b9cb to
eb8b4af
Compare
|
CCB:2021-05-05 APPROVED
|
astrogeco
added
CCB:Approved
|
CCB:2021-05-12 APPROVED |
|
@skliper please fix conflicts when you can |
skliper
force-pushed
the
fix1419-get_next_seqcnt
branch
2 times, most recently
from
7d65dca to
fb344b7
Compare
|
@astrogeco - fixed, unit tests built and passed, ready to merge! (priority for stakeholder) |
skliper
force-pushed
the
fix1419-get_next_seqcnt
branch
from
fb344b7 to
e63d483
Compare
|
Regarding the note in the context section, are any of the remaining features discussed in #1419 being encapsulated into separate issues? |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2021
nasa/cFE#1482, Resolve sequence count auto-increment rollover bug nasa/osal#985, rename hooks to handlers nasa/osal#1000, propagate status code in OS_rmdir nasa/osal#1001, rework "unit-tests" to use macros nasa/osal#1003, remove extra newlines in utassert logs nasa/osal#990, Add test for object id inline functions nasa/osal#998, fixed invalid inputs for OS_mkdir nasa/osal#812, Improves config guide documentation
No. There aren't any onboard sequence count verification requirements (or related design/implementation) at this point. We can certainly consider it if there is a stakeholder that wants to propose new requirements that aren't satisfied using the current APIs, but at this point it's probably premature. |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2021
Combines: nasa/cFE#1508, cFE v6.8.0-rc1+dev580 nasa/osal#1006, osal v5.1.0-rc1+dev452 Includes: nasa/cFE#1482, Resolve sequence count auto-increment rollover bug nasa/cFE#1491, Correctly format code block section terminator nasa/cFE#1530, Fix typos in developer guide nasa/osal#985, rename hooks to handlers nasa/osal#1000, propagate status code in OS_rmdir nasa/osal#1001, rework "unit-tests" to use macros nasa/osal#1003, remove extra newlines in utassert logs nasa/osal#990, Add test for object id inline functions nasa/osal#998, fixed invalid inputs for OS_mkdir nasa/osal#812, Improves config guide documentation nasa/osal#987, Show CodeQL Preview
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2021
Combines: nasa/cFE#1508, cFE v6.8.0-rc1+dev580 nasa/osal#1006, osal v5.1.0-rc1+dev452 Includes: nasa/cFE#1482, Resolve sequence count auto-increment rollover bug nasa/cFE#1491, Correctly format code block section terminator nasa/cFE#1530, Fix typos in developer guide nasa/osal#985, rename hooks to handlers nasa/osal#1000, propagate status code in OS_rmdir nasa/osal#1001, rework "unit-tests" to use macros nasa/osal#1003, remove extra newlines in utassert logs nasa/osal#990, Add test for object id inline functions nasa/osal#998, fixed invalid inputs for OS_mkdir nasa/osal#812, Improves config guide documentation nasa/osal#987, Show CodeQL Preview Co-Authored-By: Jake Hageman <skliper@users.noreply.github.com> Co-Authored-By: Joseph Hickey <joseph.p.hickey@nasa.gov> Co-Authored-By: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-Authored-By: Alex Campbell <zanzaben@users.noreply.github.com> Co-Authored-By: Tobias Nießen <tniessen@users.noreply.github.com> Co-Authored-By: Jonathan Bohren <jbohren-hbr@users.noreply.github.com> Co-Authored-By: Andrei Tumbar <Kronos3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1419 - Adds
CFE_MSG_GetNextSequenceCountso the auto-increment of the local sequence counter works when sending tlm (and increment is enabled). Updates unit tests and adds the old style stub. The unit tests check for the correct rollover behavior.Note - Will need to rebase when autogenerated stubs are merged, will update at that point.
Testing performed
Build and execute unit tests, passed
Expected behavior changes
Sequence count will roll over based on the mask. Before the fix the sequence counter would "stick" in telemetry until the passed in value rolled over.
System(s) tested on
Additional context
Will need to deconflict once autogenerated stubs are merged, #1463. Note this just fixes the reported bug, and doesn't add any of the other extra functionality discussed as part of #1419.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC