Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break all components into HOC wrappers and "simple" React components #43

Open
flynnplatt opened this issue Mar 16, 2018 · 0 comments
Open
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@flynnplatt
Copy link
Contributor

Inheriting from and sharing many of our components is made difficult by the fact that the default export is the result of the redux connect() function that makes them an HOC. Additionally, it means that to use those components without relying on state requires more or less duplicating the component.

If we instead created standard react components and then created wrapper components that used the connect() HOC, we could have the best of all the worlds. At the cost of inflating the number of files we have significantly.

@flynnplatt flynnplatt added enhancement New feature or request question Further information is requested labels Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants