Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify header inclusion and cmake list #22

Closed
skliper opened this issue Oct 2, 2019 · 3 comments
Closed

Simplify header inclusion and cmake list #22

skliper opened this issue Oct 2, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Oct 2, 2019

Is your feature request related to a problem? Please describe.
Complex CMakeList.txt header logic shouldn't be needed any more

Describe the solution you'd like
Include the now "external" headers for tables

Describe alternatives you've considered
None

Additional context
Related to nasa/cFE#25

Requester Info
Jacob Hageman - NASA/GSFC

@jphickey
Copy link
Contributor

jphickey commented Oct 8, 2019

Related changes here:

  • The code should NOT include cfe_tbl_internal.h any more -- this is by definition an internal file, the tool does not and should not need to use any internal definitions from CFE_TBL.
  • The references to CFE_TBL_MAX_FULL_NAME_LEN can be removed. Use sizeof(TableHeader.TableName) instead, and the alignment logic can be removed because the user should have defined CFE_MISSION_TBL_MAX_FULL_NAME_LEN as a multiple of 4 anyway.

@jphickey
Copy link
Contributor

jphickey commented Oct 8, 2019

On second look, both cases of ByteAlignFileHeaders and the associated command line option should probably be removed. It has no purpose if we are enforcing that these values are a multiple of 4 already via compile time asserts.

@skliper
Copy link
Contributor Author

skliper commented Oct 8, 2019

@jphicky are you done with this one? If so could you submit a pull request with the associated testing details? It all looks good to me.

@skliper skliper added this to the 3.2.0 milestone Oct 8, 2019
@skliper skliper added the enhancement New feature or request label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants