Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Shadowed public Members #2492

Closed
LeStarch opened this issue Jan 18, 2024 · 1 comment
Closed

Resolve Shadowed public Members #2492

LeStarch opened this issue Jan 18, 2024 · 1 comment

Comments

@LeStarch
Copy link
Collaborator

F´ Version
Affected Component

Feature Description

With the merge of #2482, shadowed public members were renamed with the a_ prefix for "argument". We should review these uses and decide how to proceed.

Rationale

Public members are discouraged but have a purpose. a_ is not a long-term solution either, but effectively resolves the issue and makes it easy to find these problems for discussion.

@JohanBertrand
Copy link
Contributor

For reference, we had some discussions about this point in a FPP issue: nasa/fpp#326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants