Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON vs XML dict have different names for parameter cmds #3116

Closed
zimri-leisher opened this issue Jan 7, 2025 · 2 comments
Closed

JSON vs XML dict have different names for parameter cmds #3116

zimri-leisher opened this issue Jan 7, 2025 · 2 comments
Labels
bug FPP Issues related to FPP

Comments

@zimri-leisher
Copy link
Collaborator

zimri-leisher commented Jan 7, 2025

F´ Version 3.5.0
Affected Component dictionaries

Problem Description

In the XML dictionary, parameter set/save commands are named:
component.XYZ_PRM_SET and component.XYZ_PRM_SAVE

In the JSON dictionary, parameter set/save commands are named:
component.XYZ_PARAM_SET and component.XYZ_PARAM_SAVE

Is this an intentional change? It breaks all sequences that depend on the old names.

Context / Environment

Execute fprime-util version-check and share the output.

Operating System: Linux
CPU Architecture: x86_64
Platform: Linux-5.15.133.1-microsoft-standard-WSL2-x86_64-with-glibc2.35
Python version: 3.10.12
CMake version: 3.22.1
Pip version: 22.0.2
Pip packages:
    fprime-tools==3.5.1
    fprime-gds==3.5.1
    fprime-fpp-*==2.2.1
Project submodules:

How to Reproduce

  1. Build Ref topology
  2. Observe difference between .xml and .json dicts

Expected Behavior

They should be the same.

@thomas-bc
Copy link
Collaborator

cc @jwest115 @bocchino

@bocchino
Copy link
Collaborator

bocchino commented Jan 8, 2025

Looks like a discrepancy between the way FPP and the Python autocoder are auto-generating the parameter commands. I moved the issue here: nasa/fpp#561.

@bocchino bocchino closed this as completed Jan 8, 2025
@bocchino bocchino added the FPP Issues related to FPP label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug FPP Issues related to FPP
Projects
None yet
Development

No branches or pull requests

3 participants