Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependencies] Lock dependency version numbers #3178

Closed
akhenry opened this issue Jul 10, 2020 · 2 comments · Fixed by #4941
Closed

[Dependencies] Lock dependency version numbers #3178

akhenry opened this issue Jul 10, 2020 · 2 comments · Fixed by #4941
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:2.0.2

Comments

@akhenry
Copy link
Contributor

akhenry commented Jul 10, 2020

Right now we are using the caret (^) version specifier in package.json for most packages. This will cause npm to use the latest minor version of a package at build time (absentpackage-lock.json). This means that packages are silently and unpredictably upgraded, leading to problems when a newer package version introduces breaking changes or bugs. Experience has taught us that both happen with unfortunate regularity.
@unlikelyzero unlikelyzero mentioned this issue Jan 28, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero added Target:1.8.5 type:maintenance tests, chores, or project maintenance labels Feb 14, 2022
@unlikelyzero unlikelyzero added this to the Target: 1.8.5 milestone Feb 14, 2022
@khalidadil
Copy link
Contributor

khalidadil commented Feb 14, 2022 •
edited
Loading

I'm still seeing the caret on several packages @unlikelyzero - was this intentional?

@unlikelyzero
Copy link
Collaborator

@khalidadil this was an older ticket that i added to #4795
Let me update master to retest this in 2.0.1

@unlikelyzero unlikelyzero reopened this Feb 15, 2022
@unlikelyzero unlikelyzero removed this from the Target: 2.0.1 milestone Mar 15, 2022
@unlikelyzero unlikelyzero reopened this Mar 15, 2022
@unlikelyzero unlikelyzero mentioned this issue Mar 15, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.0.2
Development

Successfully merging a pull request may close this issue.

[Build] 🐰🐰🐰 Remove the last carrots 🐰🐰🐰 nasa/openmct
3 participants
@khalidadil @akhenry @unlikelyzero