-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make node support explicit #3952
Labels
type:maintenance
tests, chores, or project maintenance
Milestone
Comments
This was referenced Jun 16, 2021
Not fixed. At least it doesn't look like it. I installed node 8 and it built just fine with it, no warning at all. Even more surprisingly it then ran just fine as well...
Interestingly I did get a warning when I tried the same thing with node 16. |
Need to retest this now that we've moved off of node10 |
Testing NotesAttempt to install on node 8,10,12,14,16 and verify expected ressults |
Verified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There have been a few instances in the past year where node support was not explicit and required some intervention. It's also possible that openmct is not currently capable on running on node16 and we should figure out how we want to explicitly test these versions.
We'd want to update the package.json with
"engines": { "node": ">=10.0.0" },
at least
NASA deployments are installing Open MCT system dependencies for us. We should make our node support explicit and tested in CI -- especially as we start to integrate with other NASA Systems
Related Issues
Testing Notes
The text was updated successfully, but these errors were encountered: