Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node support explicit #3952

Closed
unlikelyzero opened this issue Jun 16, 2021 · 4 comments · Fixed by #3957
Closed

Make node support explicit #3952

unlikelyzero opened this issue Jun 16, 2021 · 4 comments · Fixed by #3957
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jun 16, 2021

There have been a few instances in the past year where node support was not explicit and required some intervention. It's also possible that openmct is not currently capable on running on node16 and we should figure out how we want to explicitly test these versions.
We'd want to update the package.json with
"engines": { "node": ">=10.0.0" },
at least

NASA deployments are installing Open MCT system dependencies for us. We should make our node support explicit and tested in CI -- especially as we start to integrate with other NASA Systems

Related Issues

Testing Notes

  • Install nvm and set node version to 16+
  • Attempt to install openmct and see it fail
  • Install node version 8
  • Attempt to install openmct and see it fail
  • Install node version 10-15
  • Openmct installs correctly
@akhenry
Copy link
Contributor

akhenry commented Aug 5, 2021

Not fixed. At least it doesn't look like it. I installed node 8 and it built just fine with it, no warning at all. Even more surprisingly it then ran just fine as well...

$ rm -rf node_modules/
$ node --version
v8.17.0
$ npm install

> fsevents@1.2.13 install /Users/akhenry/Code/openmct/node_modules/watchpack-chokidar2/node_modules/fsevents
> node install.js

  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node
...etc.

Interestingly I did get a warning when I tried the same thing with node 16.

@unlikelyzero
Copy link
Collaborator Author

Need to retest this now that we've moved off of node10

@unlikelyzero
Copy link
Collaborator Author

Testing Notes

Attempt to install on node 8,10,12,14,16 and verify expected ressults

@shefalijoshi
Copy link
Contributor

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
3 participants