Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Display Layout] grid disable toggle does not hide grid in display layout #4543

Closed
2 of 5 tasks
nikhilmandlik opened this issue Dec 7, 2021 · 2 comments · Fixed by #4632
Closed
2 of 5 tasks

[Display Layout] grid disable toggle does not hide grid in display layout #4543

nikhilmandlik opened this issue Dec 7, 2021 · 2 comments · Fixed by #4632
Labels
bug:regression It used to work. Now it doesn't :( source:community Community contribution or request type:bug
Milestone
Target: 1.8.4

Comments

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Dec 7, 2021 •
edited
Loading

Summary

grid disable toggle does not hide grid in display layout

Expected vs Current Behavior

grid disable toggle should hide grid in display layout and only show grid if its enabled.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. create or use existing display layout
  2. edit mode
  3. if grid is enabled try disabling it. Screen Shot 2021-12-07 at 12 55 29 PM
  4. in display layout grid is still visible

Environment

  • Open MCT Version:
Version: 1.8.1-SNAPSHOT
Build Date: Tue Dec 07 2021 12:35:02 GMT-0800 (Pacific Standard Time)
Revision: 8acbcadd5d17e201f32f03deb753b8b12b591063
Branch: master
  • Deployment Type: VIPER
  • OS: MACOS
  • Browser: Brave

Additional Information
@nikhilmandlik nikhilmandlik added type:bug bug:regression It used to work. Now it doesn't :( labels Dec 7, 2021
@depperm depperm mentioned this issue Dec 23, 2021
Merged
8 tasks
@unlikelyzero
Copy link
Collaborator

To test:

Add a Display Layout
Click the toggle grid button (top right)

@unlikelyzero unlikelyzero added this to the Target: 1.8.4 milestone Jan 4, 2022
@unlikelyzero unlikelyzero added the source:community Community contribution or request label Jan 4, 2022
@charlesh88
Copy link
Contributor

Testathon 1-24-22: verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( source:community Community contribution or request type:bug
Projects
None yet
Milestone
Target: 1.8.4
Development

Successfully merging a pull request may close this issue.

grid toggle depperm/openmct
3 participants
@charlesh88 @nikhilmandlik @unlikelyzero