-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement the event generator as a new-style plugin #4552
Comments
@scottbell Would you mind taking a look at this? |
Wilco! |
@akhenry this looks pretty straightforward. One question though: do you want me to integrate this in with the other generators, or keep it standalone? |
Talked with @akhenry about above 👆, will keep it separate. |
FYI, I've got a working branch here: |
Testing Instructions
|
I've opened a PR for review here: |
Verified that the implementation works as specced. Have filed a followup issue to address a low priority bug - #4879 |
Summary
The Event Generator plugin provides an example of a telemetry source that produces strings. It was implemented using the legacy API (including the old type API, telemetry API, etc.).
The legacy API has not been used for new development for years and support will soon be removed completely. We want to maintain this useful example code, so we should migrate it to a plugin that defines the event type using the modern type api, as well as using the modern telemetry API.
A note on migrating Types
Types registered using the legacy bundle registration like so:
Should be migrated to the types API:
Code that was retrieving type definitions using the legacy TypeService like so:
Should now use the Open MCT type API:
The text was updated successfully, but these errors were encountered: