Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit plan views to accomodate changes to VIPER plan JSON #4882

Closed
shefalijoshi opened this issue Feb 18, 2022 · 5 comments · Fixed by #4933
Closed

Revisit plan views to accomodate changes to VIPER plan JSON #4882

shefalijoshi opened this issue Feb 18, 2022 · 5 comments · Fixed by #4933
Labels
type:enhancement

Comments

@shefalijoshi
Copy link
Contributor

The VIPER plan JSON has changed. The Plan view must be updated to accomodate changes to this JSON.

Describe the solution you'd like
Make the plan view more generic so that changes to the JSON schema don't affect the plan view as much.
This might mean a change to the viper-openmct repo as well.
@shefalijoshi shefalijoshi self-assigned this Feb 18, 2022
@shefalijoshi shefalijoshi mentioned this issue Mar 11, 2022
Merged
15 tasks
@shefalijoshi
Copy link
Contributor Author

shefalijoshi commented Mar 11, 2022 •
edited
Loading

Testing instructions:
Open a NEW VIPER plan posted by the planning tool team. (The VIPER plans folder)
Backwards compatibility - older plans that are NOT on viper-openmct should also be displayed (local deployment)

@nikhilmandlik
Copy link
Contributor

able to verify using new plan 'day1_v9_post_edit'

@unlikelyzero
Copy link
Collaborator

@shefalijoshi we need some clarity on backwards compatiblity

@unlikelyzero
Copy link
Collaborator

Verified fixed

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add source maps to map plan properties to expected properties nasa/openmct
4 participants
@nikhilmandlik @shefalijoshi @jvigliotta @unlikelyzero