Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webpack]: Move bundled javascript files into js folder when compiled #6120

Open
evenstensberg opened this issue Jan 13, 2023 · 5 comments
Open
Labels
help_wanted Help the Open MCT project! type:maintenance tests, chores, or project maintenance

Comments

@evenstensberg
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A nice way to group your resources after compilation, is through folders such as fonts, images, js, css

Describe the solution you'd like
Output js modules/bundles into a js directory in dist

Describe alternatives you've considered
N/A

Additional context

Screenshot 2023-01-13 at 15 25 37

@evenstensberg
Copy link
Contributor Author

You also won’t need sourcemaps in prod

@unlikelyzero unlikelyzero added help_wanted Help the Open MCT project! type:maintenance tests, chores, or project maintenance and removed type:enhancement labels Jan 17, 2023
@ozyx
Copy link
Contributor

ozyx commented Jan 18, 2023

Sounds great! We will just need to make sure all of our pathing is updated and correct.

You also won’t need sourcemaps in prod

Intriguing. Can you elaborate on this a bit?

@evenstensberg
Copy link
Contributor Author

evenstensberg commented Jan 18, 2023

This is probably a good first contribution issue, right? To bundle into a folder, you can set output file to myfolder/[name].js, for instance. Reference here

Intriguing. Can you elaborate on this a bit?

Not setting sourcemaps can speed up production builds if you don't need source maps for debugging in production or more files in your created application

@davetsay
Copy link
Contributor

@evenstensberg , we use production source maps to debug in integrated environments. Do you have any recommendations? Possibly a third build type?

@evenstensberg
Copy link
Contributor Author

I'd switch to a cheaper sourcemap, such as cheap-eval-sourcemap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help_wanted Help the Open MCT project! type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

No branches or pull requests

4 participants