Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bundle size by dropping moment-timezone #7393

Open
LeoDog896 opened this issue Jan 21, 2024 · 1 comment
Open

Reduce bundle size by dropping moment-timezone #7393

LeoDog896 opened this issue Jan 21, 2024 · 1 comment
Labels
type:maintenance tests, chores, or project maintenance

Comments

@LeoDog896
Copy link
Contributor

Summary

moment-timezone is massive. This is deeply ingrained in the package, and plans to reduce it are (slowly) in progress. However, given that momentjs is "a legacy project in maintenance mode", it may be better to consider other options; especially since JS isn't just a file, but needs to properly be parsed.

From manual measurement, it seems that this package takes over 768kb in the bundle (at least 18% of the current bundle size), though my estimates could be wrong.

@LeoDog896 LeoDog896 added the type:maintenance tests, chores, or project maintenance label Jan 21, 2024
@ozyx
Copy link
Contributor

ozyx commented Jan 21, 2024

We would happily accept a PR for this! It should be possible that moment can be refactored out, but we will have to be very careful as the time aspect of Open MCT is one of the most crucial and complex parts of the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

No branches or pull requests

2 participants