Merge pull request #507 from jphickey/fix-505-ut-timebase-warnings

astrogeco · web-flow · commit 9157ddedaab4 · 2020-06-23T15:21:05.000-04:00
Fix #505, warnings in time base API test
diff --git a/src/tests/time-base-api-test/time-base-api-test.c b/src/tests/time-base-api-test/time-base-api-test.c
@@ -103,11 +103,11 @@ void TestTimeBaseApi(void)
     /* Checking OS_MAX_TIMEBASES + 1 */
     for ( int i = 0; i < OS_MAX_TIMEBASES; i++ )
     {
-        snprintf(TimeBaseIter[i], 12, "TimeBase%d", i);
+        snprintf(TimeBaseIter[i], sizeof(TimeBaseIter[i]), "TimeBase%d", i);
         tbc_results[i] = OS_TimeBaseCreate(&tb_id[i], TimeBaseIter[i], 0);
     }
     TimeBaseNum = OS_MAX_TIMEBASES+1;
-    snprintf(overMaxTimeBase, 12, "TimeBase%d", TimeBaseNum);
+    snprintf(overMaxTimeBase, sizeof(overMaxTimeBase), "TimeBase%d", (int)TimeBaseNum);
     expected = OS_ERR_NO_FREE_IDS;
     actual= OS_TimeBaseCreate(&time_base_id, "overMaxTimeBase", 0);
     UtAssert_True(actual == expected, "OS_TimeBaseCreate() (%ld) == OS_ERR_NO_FREE_IDS", (long)actual);

Original file line number	Diff line number	Diff line change
`@@ -103,11 +103,11 @@ void TestTimeBaseApi(void)`
`103`	`103`	`/* Checking OS_MAX_TIMEBASES + 1 */`
`104`	`104`	`for ( int i = 0; i < OS_MAX_TIMEBASES; i++ )`
`105`	`105`	`{`
`106`		`- snprintf(TimeBaseIter[i], 12, "TimeBase%d", i);`
	`106`	`+ snprintf(TimeBaseIter[i], sizeof(TimeBaseIter[i]), "TimeBase%d", i);`
`107`	`107`	`tbc_results[i] = OS_TimeBaseCreate(&tb_id[i], TimeBaseIter[i], 0);`
`108`	`108`	`}`
`109`	`109`	`TimeBaseNum = OS_MAX_TIMEBASES+1;`
`110`		`- snprintf(overMaxTimeBase, 12, "TimeBase%d", TimeBaseNum);`
	`110`	`+ snprintf(overMaxTimeBase, sizeof(overMaxTimeBase), "TimeBase%d", (int)TimeBaseNum);`
`111`	`111`	`expected = OS_ERR_NO_FREE_IDS;`
`112`	`112`	`actual= OS_TimeBaseCreate(&time_base_id, "overMaxTimeBase", 0);`
`113`	`113`	`UtAssert_True(actual == expected, "OS_TimeBaseCreate() (%ld) == OS_ERR_NO_FREE_IDS", (long)actual);`