Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function header documentation for OS_ObjectIdAllocateNew() is incorrect #1242

Open
nohlson opened this issue Apr 1, 2022 · 1 comment
Open
Labels

Comments

@nohlson
Copy link

nohlson commented Apr 1, 2022

Describe the bug
The comments in the function header for OS_ObjectIdAllocateNew() is outdated/incorrect. I see that this was previously reported in #17 but it appears that since then the function signature and implementation has again changed.

* Inputs: last_alloc_id represents the previously issued ID of this type.

To Reproduce
N/A. Only in the function comments.

Expected behavior
Description of the function should be with the function prototype as described in #17. In this case the removal of the Inputs and Outputs sections of the function header.

Reporter Info
Nathan Ohlson

@skliper skliper added the docs label Apr 4, 2022
@skliper
Copy link
Contributor

skliper commented Apr 4, 2022

Agreed, many of function comments in osapi-idmap.c repeat, extend, or even occasionally contradict what's in os-shared-idmap.h. Should consolidate into os-shared-idmap.h and reference that documentation from osapi-idmap.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants