-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve shared layer to support lookups by keys other than ID #242
Comments
Imported from trac issue 219. Created by jphickey on 2019-06-10T10:59:18, last modified: 2019-07-26T15:13:27 |
Trac comment by jphickey on 2019-06-10 12:30:47: Pushed commit [changeset:5163c0b] on branch This was originally implemented in the context of #108 but split off for review purposes, as this was changing some general stuff in the "shared" layer that was a prerequisite for the other change set. This also touches a number of unit tests to make them more consistent, and adds some additional coverage test cases to bring the total line coverage from about 90% to 95%. |
Trac comment by jhageman on 2019-06-10 14:17:03: Reviewed with Alan C, Jonathan, Jake, and Joe 6/10/2019 |
Trac comment by jphickey on 2019-06-10 16:55:51: Updated commit incorporating review comments from 2019-06-10: Commit [changeset:65bec39] |
Trac comment by jphickey on 2019-06-12 12:38:46: Update after fixing merge/rebase issue: [changeset:614cdd3] |
Trac comment by jhageman on 2019-06-13 11:26:41: CCB 6/12/19 - CCB code reviewed and approved |
Trac comment by jphickey on 2019-06-25 11:56:35: Merged into |
Trac comment by jhageman on 2019-07-10 13:23:34: CCB 07/10/2019 - Approved for merge to dev |
Trac comment by jphickey on 2019-07-10 13:46:27: Now in the "development" branch |
Trac comment by jhageman on 2019-07-26 15:13:27: Milestone renamed |
The shared layer currently only supports object/resource lookups by ID. The code locks the table, does a direct calculation of the table index using the ID, and confirms that the ID is correct.
This supports the vast majority of OSAL calls where the subject resource is passed in using a 32-bit resource identifier.
However, there are other API calls which require lookup by name rather than ID. Some of these must continue to exist for backward compatibility, but still should use as much of the same infrastructure as possible.
The text was updated successfully, but these errors were encountered: