Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shared layer to support lookups by keys other than ID #242

Closed
skliper opened this issue Sep 30, 2019 · 10 comments
Closed

Improve shared layer to support lookups by keys other than ID #242

skliper opened this issue Sep 30, 2019 · 10 comments
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

The shared layer currently only supports object/resource lookups by ID. The code locks the table, does a direct calculation of the table index using the ID, and confirms that the ID is correct.

This supports the vast majority of OSAL calls where the subject resource is passed in using a 32-bit resource identifier.

However, there are other API calls which require lookup by name rather than ID. Some of these must continue to exist for backward compatibility, but still should use as much of the same infrastructure as possible.

@skliper skliper added this to the osal-5.0.0 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 219. Created by jphickey on 2019-06-10T10:59:18, last modified: 2019-07-26T15:13:27

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-06-10 12:30:47:

Pushed commit [changeset:5163c0b] on branch trac-219-add-search-lookups for CCB review.

This was originally implemented in the context of #108 but split off for review purposes, as this was changing some general stuff in the "shared" layer that was a prerequisite for the other change set.

This also touches a number of unit tests to make them more consistent, and adds some additional coverage test cases to bring the total line coverage from about 90% to 95%.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-06-10 14:17:03:

Reviewed with Alan C, Jonathan, Jake, and Joe 6/10/2019

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-06-10 16:55:51:

Updated commit incorporating review comments from 2019-06-10:

Commit [changeset:65bec39]

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-06-12 12:38:46:

Update after fixing merge/rebase issue: [changeset:614cdd3]

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-06-13 11:26:41:

CCB 6/12/19 - CCB code reviewed and approved

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-06-25 11:56:35:

Merged into ic-ccb-20190612

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-10 13:23:34:

CCB 07/10/2019 - Approved for merge to dev

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2019-07-10 13:46:27:

Now in the "development" branch

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-26 15:13:27:

Milestone renamed

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper modified the milestones: osal-5.0.0, 5.0.0 Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant