Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Includes suggested fix]: Ediff highlights rather unreadable #162

Open
ianyepan opened this issue Mar 22, 2020 · 2 comments
Open

[Includes suggested fix]: Ediff highlights rather unreadable #162

ianyepan opened this issue Mar 22, 2020 · 2 comments

Comments

@ianyepan
Copy link
Contributor

Here is a screenshot that showcases the highlights in ediff. Sadly, the high contrast of colours appear to be rather unreadable.

Screenshot 2020-03-22 at 22 26 28

My fix:

I've been experimenting with the colours and decide to use the ones from magit diffs:

(ediff-fine-diff-A        ((t (:background "#663333" :foreground "#eecccc" :extend t))))
(ediff-fine-diff-B        ((t (:background "#336633" :foreground "#cceecc" :extend t))))
(ediff-fine-diff-C        ((t (:background "#333366" :foreground "#ccccee" :extend t))))

Here is the result.

Screenshot 2020-03-22 at 22 25 34

IMHO, this looks a lot more consistent with the design principle of the rest of the colourscheme, and also improves readability of diff hunks.

@nashamri
Copy link
Owner

Your fix does look much better, I just need to find the time and prepare the alternative set of colors for the light variant. 👍

@ianyepan
Copy link
Contributor Author

ianyepan commented Apr 1, 2020

Absolutely! P.s. Magit does have some good colour choices that might of help :)
Thx again for considering the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants