Refactorization and mixed view #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and correct JavaScript and CSS contents. Introduce the mixed view (both vertical and horizontal).
|
Looks great, thanks! I'll update the extension on the store today. |
sudonatalie
added a commit
that referenced
this pull request
Mar 11, 2015
Refactorization and mixed view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new state for the list, the mixed view. It displays lists in a grid fashion, with vertical overflow.
Now whenever you click the button it loops through the three states: mixed, vertical, normal.
I also included zaucy's commit and updated his CSS file with the latest code from the original app.
Finally, I cleaned up the code a bit and removed some unnecessary parts.