Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-defined LS factor? #735

Closed
phargogh opened this issue Nov 29, 2021 · 2 comments
Closed

Allow user-defined LS factor? #735

phargogh opened this issue Nov 29, 2021 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@phargogh
Copy link
Member

A user on the forums had this suggestion:

Dear InVEST developers

The new interface of the model is looking great. However, as I suggested in my previous comment, the LS factor in the SDR sub-model is still can not be customized. In other words, users are not allowed to calculate the LS factor with another formula. My strong suggestion is the LS factor in the SDR sub-model should be put like the advanced and default options of the seasonal water yield sub-model. In general, two options (i.e., one user-defined and another with default) are needed for calculating the LS factor in the SDR sub-model. I hope that my suggestions will be considered in the next version of the model.

I don't recall the details of our LS factor implementation, but this sounds like a reasonable request and there may be some precedent for this in some of the other hydro models. Either way, it'd be helpful to record our decision about this in this issue thread.

@phargogh phargogh added enhancement New feature or request question Further information is requested labels Nov 29, 2021
@emlys
Copy link
Member

emlys commented Jan 14, 2022

We should talk with a hydrologist in order to make a decision about this.

@phargogh
Copy link
Member Author

phargogh commented May 4, 2023

Some of this will probably be addressed by the updated LS factor #915 since our LS Factor will be more in line with what people expect.

@natcap natcap locked and limited conversation to collaborators May 4, 2023
@phargogh phargogh converted this issue into discussion #1300 May 4, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants