Skip to content

Latest commit

 

History

History
20 lines (18 loc) · 950 Bytes

PULL_REQUESTS.md

File metadata and controls

20 lines (18 loc) · 950 Bytes

Pull Requests

Back to Team Agreement

  • PR template filled out - PULL_REQUEST_TEMPLATE.md
    • Optional - On UI changes PR includes gif of the change
  • Test and review your own code before getting others involved
  • Tag people who originally wrote the code and/or experts in that area of the code for code review
  • Optional - deploy the latest commit out to a place it can be tested on wk-dev to speed up the +QA process
  • All pull requests MUST be tied to a JIRA ticket.
  • Add the "HOLD" label:
    • if you addressing comments or making large changes
    • if you aren't ready for the PR to be reviewed
  • Close your PR:
    • if you aren't actively working on it
    • if it won't be ready for review =TODAY()
    • if you don't get that joke ^

Additional Reading

10 Tips for better Pull Requests