fix: argCheck flip boolean check

natecraddock · natecraddock · commit 00abb7d9d32e · 2023-04-01T09:08:53.000-06:00
Argcheck was incorrectly checking for `true` rather than `false` for
raising an error.
diff --git a/src/ziglua-5.1/lib.zig b/src/ziglua-5.1/lib.zig
@@ -1106,7 +1106,7 @@ pub const Lua = struct {
     /// See https://www.lua.org/manual/5.1/manual.html#luaL_argcheck
     pub fn argCheck(lua: *Lua, cond: bool, arg: i32, extra_msg: [:0]const u8) void {
         // translate-c failed
-        if (cond) lua.argError(arg, extra_msg);
+        if (!cond) lua.argError(arg, extra_msg);
     }
 
     /// Raises an error reporting a problem with argument `arg` of the C function that called it
diff --git a/src/ziglua-5.1/tests.zig b/src/ziglua-5.1/tests.zig
@@ -1134,7 +1134,7 @@ test "args and errors" {
 
     const argCheck = ziglua.wrap(struct {
         fn inner(l: *Lua) i32 {
-            l.argCheck(true, 1, "error!");
+            l.argCheck(false, 1, "error!");
             return 0;
         }
     }.inner);
diff --git a/src/ziglua-5.2/lib.zig b/src/ziglua-5.2/lib.zig
@@ -1298,7 +1298,7 @@ pub const Lua = struct {
     /// See https://www.lua.org/manual/5.2/manual.html#lua_argcheck
     pub fn argCheck(lua: *Lua, cond: bool, arg: i32, extra_msg: [:0]const u8) void {
         // translate-c failed
-        if (cond) lua.argError(arg, extra_msg);
+        if (!cond) lua.argError(arg, extra_msg);
     }
 
     /// Raises an error reporting a problem with argument `arg` of the C function that called it
diff --git a/src/ziglua-5.2/tests.zig b/src/ziglua-5.2/tests.zig
@@ -1274,7 +1274,7 @@ test "args and errors" {
 
     const argCheck = ziglua.wrap(struct {
         fn inner(l: *Lua) i32 {
-            l.argCheck(true, 1, "error!");
+            l.argCheck(false, 1, "error!");
             return 0;
         }
     }.inner);
diff --git a/src/ziglua-5.3/lib.zig b/src/ziglua-5.3/lib.zig
@@ -1350,7 +1350,7 @@ pub const Lua = struct {
     /// See https://www.lua.org/manual/5.3/manual.html#luaL_argcheck
     pub fn argCheck(lua: *Lua, cond: bool, arg: i32, extra_msg: [:0]const u8) void {
         // translate-c failed
-        if (cond) lua.argError(arg, extra_msg);
+        if (!cond) lua.argError(arg, extra_msg);
     }
 
     /// Raises an error reporting a problem with argument `arg` of the C function that called it
diff --git a/src/ziglua-5.3/tests.zig b/src/ziglua-5.3/tests.zig
@@ -1299,7 +1299,7 @@ test "args and errors" {
 
     const argCheck = ziglua.wrap(struct {
         fn inner(l: *Lua) i32 {
-            l.argCheck(true, 1, "error!");
+            l.argCheck(false, 1, "error!");
             return 0;
         }
     }.inner);
diff --git a/src/ziglua-5.4/lib.zig b/src/ziglua-5.4/lib.zig
@@ -1387,7 +1387,7 @@ pub const Lua = struct {
     /// See https://www.lua.org/manual/5.4/manual.html#lua_argcheck
     pub fn argCheck(lua: *Lua, cond: bool, arg: i32, extra_msg: [:0]const u8) void {
         // translate-c failed
-        if (cond) lua.argError(arg, extra_msg);
+        if (!cond) lua.argError(arg, extra_msg);
     }
 
     /// Raises an error reporting a problem with argument `arg` of the C function that called it
diff --git a/src/ziglua-5.4/tests.zig b/src/ziglua-5.4/tests.zig
@@ -1384,7 +1384,7 @@ test "args and errors" {
 
     const argCheck = ziglua.wrap(struct {
         fn inner(l: *Lua) i32 {
-            l.argCheck(true, 1, "error!");
+            l.argCheck(false, 1, "error!");
             return 0;
         }
     }.inner);

Original file line number	Diff line number	Diff line change
`@@ -1106,7 +1106,7 @@ pub const Lua = struct {`
`1106`	`1106`	`/// See https://www.lua.org/manual/5.1/manual.html#luaL_argcheck`
`1107`	`1107`	`pub fn argCheck(lua: *Lua, cond: bool, arg: i32, extra_msg: [:0]const u8) void {`
`1108`	`1108`	`// translate-c failed`
`1109`		`- if (cond) lua.argError(arg, extra_msg);`
	`1109`	`+ if (!cond) lua.argError(arg, extra_msg);`
`1110`	`1110`	`}`
`1111`	`1111`
`1112`	`1112`	/// Raises an error reporting a problem with argument `arg` of the C function that called it
Original file line number	Diff line number	Diff line change
`@@ -1134,7 +1134,7 @@ test "args and errors" {`
`1134`	`1134`
`1135`	`1135`	`const argCheck = ziglua.wrap(struct {`
`1136`	`1136`	`fn inner(l: *Lua) i32 {`
`1137`		`- l.argCheck(true, 1, "error!");`
	`1137`	`+ l.argCheck(false, 1, "error!");`
`1138`	`1138`	`return 0;`
`1139`	`1139`	`}`
`1140`	`1140`	`}.inner);`
Original file line number	Diff line number	Diff line change
`@@ -1298,7 +1298,7 @@ pub const Lua = struct {`
`1298`	`1298`	`/// See https://www.lua.org/manual/5.2/manual.html#lua_argcheck`
`1299`	`1299`	`pub fn argCheck(lua: *Lua, cond: bool, arg: i32, extra_msg: [:0]const u8) void {`
`1300`	`1300`	`// translate-c failed`
`1301`		`- if (cond) lua.argError(arg, extra_msg);`
	`1301`	`+ if (!cond) lua.argError(arg, extra_msg);`
`1302`	`1302`	`}`
`1303`	`1303`
`1304`	`1304`	/// Raises an error reporting a problem with argument `arg` of the C function that called it
Original file line number	Diff line number	Diff line change
`@@ -1274,7 +1274,7 @@ test "args and errors" {`
`1274`	`1274`
`1275`	`1275`	`const argCheck = ziglua.wrap(struct {`
`1276`	`1276`	`fn inner(l: *Lua) i32 {`
`1277`		`- l.argCheck(true, 1, "error!");`
	`1277`	`+ l.argCheck(false, 1, "error!");`
`1278`	`1278`	`return 0;`
`1279`	`1279`	`}`
`1280`	`1280`	`}.inner);`
Original file line number	Diff line number	Diff line change
`@@ -1350,7 +1350,7 @@ pub const Lua = struct {`
`1350`	`1350`	`/// See https://www.lua.org/manual/5.3/manual.html#luaL_argcheck`
`1351`	`1351`	`pub fn argCheck(lua: *Lua, cond: bool, arg: i32, extra_msg: [:0]const u8) void {`
`1352`	`1352`	`// translate-c failed`
`1353`		`- if (cond) lua.argError(arg, extra_msg);`
	`1353`	`+ if (!cond) lua.argError(arg, extra_msg);`
`1354`	`1354`	`}`
`1355`	`1355`
`1356`	`1356`	/// Raises an error reporting a problem with argument `arg` of the C function that called it
Original file line number	Diff line number	Diff line change
`@@ -1299,7 +1299,7 @@ test "args and errors" {`
`1299`	`1299`
`1300`	`1300`	`const argCheck = ziglua.wrap(struct {`
`1301`	`1301`	`fn inner(l: *Lua) i32 {`
`1302`		`- l.argCheck(true, 1, "error!");`
	`1302`	`+ l.argCheck(false, 1, "error!");`
`1303`	`1303`	`return 0;`
`1304`	`1304`	`}`
`1305`	`1305`	`}.inner);`
Original file line number	Diff line number	Diff line change
`@@ -1387,7 +1387,7 @@ pub const Lua = struct {`
`1387`	`1387`	`/// See https://www.lua.org/manual/5.4/manual.html#lua_argcheck`
`1388`	`1388`	`pub fn argCheck(lua: *Lua, cond: bool, arg: i32, extra_msg: [:0]const u8) void {`
`1389`	`1389`	`// translate-c failed`
`1390`		`- if (cond) lua.argError(arg, extra_msg);`
	`1390`	`+ if (!cond) lua.argError(arg, extra_msg);`
`1391`	`1391`	`}`
`1392`	`1392`
`1393`	`1393`	/// Raises an error reporting a problem with argument `arg` of the C function that called it
Original file line number	Diff line number	Diff line change
`@@ -1384,7 +1384,7 @@ test "args and errors" {`
`1384`	`1384`
`1385`	`1385`	`const argCheck = ziglua.wrap(struct {`
`1386`	`1386`	`fn inner(l: *Lua) i32 {`
`1387`		`- l.argCheck(true, 1, "error!");`
	`1387`	`+ l.argCheck(false, 1, "error!");`
`1388`	`1388`	`return 0;`
`1389`	`1389`	`}`
`1390`	`1390`	`}.inner);`