Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enabling INP ruff rules by default #128

Open
nathanjmcdougall opened this issue Nov 18, 2024 · 0 comments
Open

Consider enabling INP ruff rules by default #128

nathanjmcdougall opened this issue Nov 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nathanjmcdougall
Copy link
Owner

Motivation
Missing __init__.py can cause problems for various tools, e.g. import-linter.
There's a question of whether this should be enabled by default or only when using import-linter. In any case, we should definitely try and re-add if it's been removed, when adding import-linter.
Disable it for the tests dir.

There's a repo which provides an autofix: https://github.com/lk16/detect-missing-init
But I'd be concerned about a different heuristic from ruff so I'm inclined to not use this. It's really an upstream ruff feature request.

Summary of desired enhancement
Enable the INP ruff rule as appropriate.

@nathanjmcdougall nathanjmcdougall self-assigned this Nov 18, 2024
@nathanjmcdougall nathanjmcdougall added the enhancement New feature or request label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant