Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tox for development and consider supporting it #140

Closed
nathanjmcdougall opened this issue Nov 21, 2024 · 1 comment
Closed

Use tox for development and consider supporting it #140

nathanjmcdougall opened this issue Nov 21, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@nathanjmcdougall
Copy link
Owner

Motivation
At the moment, there is a significant amount of complexity in the codebase just with managing the Bitbucket Pipelines CI. I wonder whether tox is usually overkill for most projects, but it might be the right approach for usethis, because it makes it much easier to switch between CI providers (and makes supporting those providers much simpler). Bitbucket pipelines also has no notion of test matrices so it makes the syntax quite verbose which isn't ideal.

I think it would be good to add tox for development of this project and then see how the setup goes; are there pain points with the existing approach?

Will definitely want to use tox-uv.

Summary of desired enhancement
Consider using tox. Start by adding it for development, and consider the pros and cons for inclusion in usethis itself.

@nathanjmcdougall nathanjmcdougall added the enhancement New feature or request label Nov 21, 2024
@nathanjmcdougall nathanjmcdougall self-assigned this Nov 21, 2024
@nathanjmcdougall
Copy link
Owner Author

I have done a fair bit of reading on tox and I am still not really understanding what use case it is trying to solve. This blog post definitely has me leaning against it:
https://lukasatkinson.de/2025/just-dont-tox/

I think the conclusions are right that uv plus task runner (which hopefully will be in uv soonish, see #131) serves the main purposes of tox. But I am not entirely sure.

For usethis, the benefits would be if we can reduce duplication between CI configs, but:

  • Different CIs have fairly different mechanisms, e.g. bitbucket doesn't support matrices
  • People very rarely want to use multiple CIs simultaneously so it's only a benefit to reduce the complexity of usethis itself, not the user
  • The current approach is working find so the value added by spending the time on this is probably minimal.

On that basis, and because even now after watching this video and reading the docs, I don't have clarity on the use case for tox, I am going to close this issue for now.

@nathanjmcdougall nathanjmcdougall closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant