Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KeybordEvent.char #3634

Closed
mhenkens opened this issue Sep 18, 2023 · 0 comments · Fixed by #3635
Closed

Remove KeybordEvent.char #3634

mhenkens opened this issue Sep 18, 2023 · 0 comments · Fixed by #3635
Assignees
Labels

Comments

@mhenkens
Copy link
Contributor

The event.char code is deprecated and remove from TypeScript 4.6.4

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The event.char code is deprecated and remove from TypeScript 4.6.4

Expected behavior

not used event.chat anymore

see: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key/Key_Values

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z
Stark version: 12.0.0


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@mhenkens mhenkens self-assigned this Sep 18, 2023
@mhenkens mhenkens added 12.x Stark version type: feature labels Sep 18, 2023
mhenkens added a commit to mhenkens/stark that referenced this issue Sep 18, 2023
KeybordEvent.char is deprecated and will be remove from typesscript. To prepare the update to
angular 13 we need to remveoved occureneces

ISSUES CLOSED: NationalBankBelgium#3634
mhenkens added a commit to mhenkens/stark that referenced this issue Sep 22, 2023
KeybordEvent.char is deprecated and will be remove from typesscript. To prepare the update to
angular 13 we need to remveoved occureneces

ISSUES CLOSED: NationalBankBelgium#3634
mhenkens added a commit to mhenkens/stark that referenced this issue Sep 22, 2023
KeybordEvent.char is deprecated and will be remove from typesscript. To prepare the update to
angular 13 we need to remveoved occureneces

ISSUES CLOSED: NationalBankBelgium#3634
mhenkens added a commit to mhenkens/stark that referenced this issue Sep 22, 2023
KeybordEvent.char is deprecated and will be remove from typesscript. To prepare the update to
angular 13 we need to remveoved occureneces

ISSUES CLOSED: NationalBankBelgium#3634
mhenkens added a commit to mhenkens/stark that referenced this issue Sep 22, 2023
KeybordEvent.char is deprecated and will be remove from typesscript. To prepare the update to
angular 13 we need to remveoved occureneces

ISSUES CLOSED: NationalBankBelgium#3634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant