Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keep-alive components weird issue #291

Merged
merged 4 commits into from
Aug 1, 2018
Merged

Fix keep-alive components weird issue #291

merged 4 commits into from
Aug 1, 2018

Conversation

msaelices
Copy link

See #220

@msaelices msaelices requested a review from rigor789 August 1, 2018 02:09
@msaelices msaelices mentioned this pull request Aug 1, 2018
Closed
@rigor789
Copy link
Member

rigor789 commented Aug 1, 2018

Seems to be fixing the issue, I added assertions to the tests, as well as reset the prevSibling too.

@rigor789 rigor789 merged commit a953db5 into master Aug 1, 2018
@msaelices msaelices deleted the pr/220 branch August 1, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 Awaiting requested review from rigor789

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msaelices @rigor789