-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frame and router - a new hope (through factory extensibility) #321
Merged
rigor789
merged 17 commits into
nativescript-vue:frame-and-router
from
bundyo:frame-and-router
Sep 13, 2018
Merged
Frame and router - a new hope (through factory extensibility) #321
rigor789
merged 17 commits into
nativescript-vue:frame-and-router
from
bundyo:frame-and-router
Sep 13, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temp: test some performance tweaks
add: export router from ns-vue
Closed
rigor789
added a commit
that referenced
this pull request
Sep 18, 2018
* feat(frame and page): added frame and page component wrappers This change should allow a frame which is not topmost to still navigate a child page * feat: handle backstack caching / restoring * refactor: wip frame/page changes * feat(frame): fire frame events from the frame wrapper * feat: allow passing frame to $navigateTo BREAKING CHANGE: the options object of $navigateTo has been simplified fix #213 * refactor: add frames to sample * refactor: add <Frame> element to all samples * Fix typo error which happens in case-sensitive filesystems. * Add <Frame> node to all the samples. * refactor: remove configuration object from $start * fix: wrong conditional for v-for warning on listview * feat: inject hasRouterView property during template compilation * refactor: remove navigation call from renderer * feat: add support for <router-view> in Frame and fix wrong parent frame search function * refactor: add back button handler to sample - optional * refactor: remove old RouterPlugin * feat: <router-view> nested in <Frame> (#286) * chore: update backers * feat: Starting router chores * horror: Juggling router-views * fix: rollup * fix: Add a missing method. * add: frame transition support * fix: back transition not detected add: back transition auto flips direction (for predefined {N} transitions) - configurable with back-transition="flip|mirror" - default: flip. * chore: Remove some nextTicks that are seemingly not needed. chore: cache regexps. add: Try adding some profiling stats. * add: remove buble in order to use ES2015+ as both Android and iOS engines are quite new. add: Add some ES2015+ operators where possible add: return elements where they should be returnes add: start implementing support for push/replace/go with animation object. fix: change one deprecated command * fix: specifying Page transition on push/replace/go. chore: convert NativeScriptHistory to class. * fix: remove the back-transition setting, as it breaks page reusability. This breaks ListView events after back navigation though. * fix: the back problem (hopefully) - needs more testing first * fix: remove buble references fix: speed up default slide transitions to match Angular ones add: prop.decode modifier to decode HTML entities * fix: the page is still reactive while leaving it - causes changes to $route to be visible. * fix: really destroy the page when it should be (previous on back navigation) * fix: router back on app root * fix: iOS back button skips the router chore: some formatting * fix: rename transition props to ios:transition and android:transition * refactor: clean up unneded code * chore: build into samples dir * test: update sample app for router v2 * Sample app for testing routing with vue-router, tabs and RadSideDrawer. See #292 * fix: fixed . See #292 * feat: frame and router changes (#321) * add: dev:dist script to run ns-vue locally * chore: refactor router plugin to History only * fix: remove default on require temp: test some performance tweaks * fix: formatting * fix: the way router is used add: export router from ns-vue * fix: router replace * chore: formatting * chore: formatting * fix: better plugin and remove router from ns-vue * fix: use a simpler factory mixin for the extensibility point * fix: back transition after mingling with components * fix: possibility to stop back button handling * add: start implementing router cache * fix: simplify page * fix: more simplification * chore: remove a row * fix: linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.