Fix listview cell recycling #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the same note, should we change PRed... |
|
I can't recall the exact reason we had to use |
|
Is this fix released? |
|
@topclaudy yes in an alpha release (it is safe to upgrade - I have been using the latest alpha for a while) https://github.com/nativescript-vue/nativescript-vue/releases/tag/v2.5.0-alpha.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565.
The
<NativeListView>was not setting theitemTemplatesproperty correctly.I am not sure why it was setting
_itemTemplatesInternalinstead ofitemTemplatesbefore, but now it works. According to my tests, the cell recycling works properly with multi-templates and the scroll is visibly smoother.For comparison of a before/after, see the updated playground app. The list on the right is patched with this fix.