Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output method to either accept a format function or supress logs on test environment #4

Open
f3liperamos opened this issue Nov 30, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@f3liperamos
Copy link
Contributor

image

The problem
Logger's output method ends with a console.log call.
Our only option, today, to test if it outputs correctly is to test if format is properly called.

Sugestion
Make output able to receive a custom format option, which I see as a better solution than next one.

or change output method to either return the formated/requested value and supress console.log on test environments

@f3liperamos f3liperamos added the enhancement New feature or request label Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant