Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix article links colour on dark mode #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grmbyrn
Copy link
Contributor

@grmbyrn grmbyrn commented Dec 19, 2023

I have updated the article titles to appear in white when the page is in dark mode. This change ensures better visibility and accessibility for users.

Changes Made:

Adjusted the CSS for article titles to use white colour in dark mode.

Additional Notes:

Titles appeared white in dark mode when page viewed locally, but black when viewed on https://secure-git.guide/ so it was tricky to identify the cause. If the issue persists, please let me know.

@cgbosse
Copy link
Member

cgbosse commented Dec 19, 2023

Hi @grmbyrn,

If this is related to issue #78 then I think there is a different way of referencing this. Please ask @josecelano how to do this properly. I assume that this is the solution that has not been merged yet that you mentioned to have done in #78 .

Thank you.

@grmbyrn
Copy link
Contributor Author

grmbyrn commented Dec 19, 2023

Hi @cgbosse, yes this is the pull request mentioned in #78. @josecelano, is there another way this should be referenced?

@josecelano josecelano linked an issue Dec 20, 2023 that may be closed by this pull request
@josecelano
Copy link
Member

Hi @cgbosse, yes this is the pull request mentioned in #78. @josecelano, is there another way this should be referenced?

image

@josecelano
Copy link
Member

Hi @grmbyrn if you run npm run preview is still not working:

image

@josecelano
Copy link
Member

With dev:

image

With preview:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With the dark theme you cannot see the article list
3 participants