Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide docker image #65

Open
danielvladco opened this issue Jul 12, 2019 · 5 comments
Open

provide docker image #65

danielvladco opened this issue Jul 12, 2019 · 5 comments

Comments

@danielvladco
Copy link

Is it planning for the future to provide an official docker image for this project? I think It would be very convenient.

@AlecAivazis
Copy link
Member

Most definitely! I was holding off until I understood a little bit better how the gateway was being used. My hunch is that for more usecases a custom binary will have to be built, reducing the usefulness of a pre-build docker image apart from quick demos

@jakubknejzlik
Copy link

Hello! First of all, thanks for this great library. It's unfortunate that I didn't find it earlier as I'm currently migrating multiple services from Node.js to Go and gateway was the last piece of the puzzle. And this library looks like win:win situation 🎉.
I'm currently using my version of Node.js gateway (basic schema stitching) that can be found here: https://github.com/graphql-services/graphql-gateway ...I created implementation of nautilus version (branch feature/nautilus-gateway) and if you want to use docker image until this repository has official one, feel free:

docker run --rm -it -p 8080:80 -e GRAPHQL_URL=https://example.com/graphql graphql/gateway:feature-nautilus-gateway

I just successfully deployed it to one of our test environments and it seems to work smoothly :)

@AlecAivazis
Copy link
Member

Thanks for the positive feedback! I'm happy to know that this library is helping you out!

Please let me know if you run into any problems. I don't have a huge amount of time for feature requests atm but I can definitely work on bugs that pop up.

@remorses
Copy link

remorses commented Jan 31, 2020

I would like to use this project as a docker image to make a gateway between different services in a docker-compose stack.

To be used like that it needs

  • CORS support, configured via env
  • URLS via env
  • Ability to forward headers
  • Ability to wait until urls are reachable (until a TIMEOUT given via env)

@AlecAivazis do you agree?

I would be happy to contribute

@AlecAivazis
Copy link
Member

Hey @remorses - thanks for the +1 for a docker image. I think you're right that what you outlined would cover most peoples' requirements. It would also be a great way for people to get started with the gateway if they already have docker installed.

If you or @danielvladco want to put something together, I would love to review it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants