Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie updated by NetworkToCode Cookie Drift Manager Tool #343

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

nautobot-bot
Copy link

Template:

{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.1.0",
    "path": null
}

Cookie:

{
    "remote": "https://github.com/nautobot/nautobot-app-ssot.git",
    "path": "/tmp/tmpufir1e56/nautobot-app-ssot",
    "repository_path": "/tmp/tmpufir1e56/nautobot-app-ssot",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@smith-ntc",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "app_name": "nautobot_ssot",
        "verbose_name": "Single Source of Truth",
        "app_slug": "nautobot-ssot",
        "project_slug": "nautobot-app-ssot",
        "repo_url": "https://github.com/nautobot/nautobot-app-ssot/",
        "base_url": "ssot",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotSSOTApp",
        "project_short_description": "Nautobot Single Source of Truth",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/ssot/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpufir1e56",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.1.0"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "802b921a43ac6c3a5bfe059c4feccc8eef629fed",
    "draft": true
}

CLI Arguments:

{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.1.0",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false,
    "draft": null
}

Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.1.0",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-app-ssot.git",
    "path": "/tmp/tmpufir1e56/nautobot-app-ssot",
    "repository_path": "/tmp/tmpufir1e56/nautobot-app-ssot",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@smith-ntc",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "app_name": "nautobot_ssot",
        "verbose_name": "Single Source of Truth",
        "app_slug": "nautobot-ssot",
        "project_slug": "nautobot-app-ssot",
        "repo_url": "https://github.com/nautobot/nautobot-app-ssot/",
        "base_url": "ssot",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotSSOTApp",
        "project_short_description": "Nautobot Single Source of Truth",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/ssot/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpufir1e56",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.1.0"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "802b921a43ac6c3a5bfe059c4feccc8eef629fed",
    "draft": true
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.1.0",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false,
    "draft": null
}
```
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few issues that need to be addressed/discussed before we can consider this read to merge.

@@ -218,12 +229,30 @@ jobs:
if: "matrix.db-backend == 'mysql'"
- name: "Run Tests"
run: "poetry run invoke unittest"
changelog:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use towncrier in this project so I'm unsure of if this is required or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Towncrier is added in this PR as a standard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Towncrier is added in this PR as a standard

I think we need to discuss this internally. I don't recall us ever having an agreement that towncrier would be required dependency for all projects.

README.md Outdated Show resolved Hide resolved
docs/admin/compatibility_matrix.md Outdated Show resolved Hide resolved
docs/admin/compatibility_matrix.md Outdated Show resolved Hide resolved
docs/admin/release_notes/version_1.0.md Outdated Show resolved Hide resolved
docs/admin/upgrade.md Outdated Show resolved Hide resolved
nautobot_ssot/__init__.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@snaselj snaselj marked this pull request as ready for review January 31, 2024 12:57
@snaselj snaselj requested a review from a team as a code owner January 31, 2024 12:57
@snaselj
Copy link
Contributor

snaselj commented Jan 31, 2024

This pull request has been cleaned up and is ready for review now.

@snaselj snaselj requested a review from jdrew82 January 31, 2024 12:57
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few things we need to discuss internally before I can approve this and merge it.

@jdrew82 jdrew82 added status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation status: internal review Internal discussion is required to move forward with issue type: documentation Issues/PRs addressing documentation. labels Feb 1, 2024
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@snaselj
Copy link
Contributor

snaselj commented Mar 7, 2024

Rebased on top of develop to resolve conflicts.

@jdrew82 jdrew82 merged commit aecbf0f into develop Mar 8, 2024
17 checks passed
@jdrew82 jdrew82 deleted the drift-manager/pr branch March 8, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation status: internal review Internal discussion is required to move forward with issue type: documentation Issues/PRs addressing documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants