Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPFabric technology calls to us all #413

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

jmcgill298
Copy link
Contributor

Previously these were using fetch, which does not collect all results. Switching this to use all will get all relevant data points.

@jmcgill298 jmcgill298 requested review from alhogan and a team as code owners April 2, 2024 17:56
Copy link
Contributor

@alhogan alhogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmcgill298 jmcgill298 force-pushed the jacobm/ipfabric/fix-technology-calls branch from be40ad3 to 9f3b7e3 Compare April 2, 2024 21:04
Previously these were using `fetch`, which does not collect all results.
Switching this to use `all` will get all relevant data points.
@jmcgill298 jmcgill298 force-pushed the jacobm/ipfabric/fix-technology-calls branch from 9f3b7e3 to 4780efb Compare April 2, 2024 22:20
@Kircheneer Kircheneer merged commit 04b9110 into develop Apr 4, 2024
16 checks passed
@jmcgill298 jmcgill298 deleted the jacobm/ipfabric/fix-technology-calls branch April 4, 2024 13:46
This was referenced Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants