Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceNow 2.X fails #449

Open
itdependsnetworks opened this issue May 5, 2024 · 2 comments
Open

ServiceNow 2.X fails #449

itdependsnetworks opened this issue May 5, 2024 · 2 comments
Labels
integration: servicenow Issues originally from standalone ServiceNow SSoT repo type: bug Issues/PRs addressing a bug.

Comments

@itdependsnetworks
Copy link
Contributor

Environment

  • Python version: 3.11
  • Nautobot version: 2.1.8
  • nautobot-ssot version: 2.6.1

Expected Behavior

Working job

Observed Behavior

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/celery/app/trace.py", line 477, in trace_task
    R = retval = fun(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/nautobot/extras/jobs.py", line 153, in __call__
    return self.run(*args, **deserialized_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/nautobot/.local/lib/python3.11/site-packages/nautobot_ssot/integrations/servicenow/jobs.py", line 89, in run
    super().run(dryrun, memory_profiling, *args, **kwargs)
  File "/opt/nautobot/.local/lib/python3.11/site-packages/nautobot_ssot/jobs/base.py", line 317, in run
    self.sync_data(memory_profiling)
  File "/opt/nautobot/.local/lib/python3.11/site-packages/nautobot_ssot/jobs/base.py", line 145, in sync_data
    self.load_target_adapter()
  File "/opt/nautobot/.local/lib/python3.11/site-packages/nautobot_ssot/integrations/servicenow/jobs.py", line 82, in load_target_adapter
    self.target_adapter.load()
  File "/opt/nautobot/.local/lib/python3.11/site-packages/nautobot_ssot/integrations/servicenow/diffsync/adapter_servicenow.py", line 83, in load
    ancestor = self.site_filter.region
               ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Location' object has no attribute 'region'

Has not been updated to be 2.x compatible since it is referencing region.

Steps to Reproduce

  1. Run ServiceNow job
@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: servicenow Issues originally from standalone ServiceNow SSoT repo labels Jul 18, 2024
@bryanculver
Copy link
Member

@itdependsnetworks I'm guessing "ServiceNow 2.X fails" means "ServiceNow SSoT Integration needs to be made compatible with Nautobot 2.X", not "ServiceNow SSoT Integration needs to be made compatible with ServiceNow 2.X"

@bryanculver
Copy link
Member

We should add developer docs on how to setup a ServiceNow instance for testing or at least how to access an existing ServiceNow instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: servicenow Issues originally from standalone ServiceNow SSoT repo type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

No branches or pull requests

3 participants